Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate failed img pull error to response line #1302

Merged
merged 4 commits into from
Sep 14, 2023
Merged

fix: propagate failed img pull error to response line #1302

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba7c5cb
return before inaccurate log message is logged
tedim52 Sep 14, 2023
30aeae2
propagate err from failed image pull
tedim52 Sep 14, 2023
afbdd27
Merge branch 'main' into tedi/prop-img-err
tedim52 Sep 14, 2023
3c5c5ec
wrap with validation err
tedim52 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rver/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ func fetchImageFromBackend(ctx context.Context, wg *sync.WaitGroup, imageCurrent
err := (*backend).FetchImage(ctx, image)
if err != nil {
logrus.Warnf("Container image '%s' download failed. Error was: '%s'", image, err.Error())
pullErrors <- startosis_errors.NewValidationError("Failed fetching the required image '%v', make sure that the image exists and is public", image)
pullErrors <- startosis_errors.NewValidationError("Failed fetching the required image '%v' due to the following error: %v\n", image, err.Error())
tedim52 marked this conversation as resolved.
Show resolved Hide resolved
return
tedim52 marked this conversation as resolved.
Show resolved Hide resolved
}
logrus.Debugf("Container image '%s' successfully downloaded", image)
}