fix: warn instead of failing for json log line parse error #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeeekay
approved these changes
Sep 20, 2023
h4ck3rk3y
pushed a commit
that referenced
this pull request
Sep 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.83.5](0.83.4...0.83.5) (2023-09-21) ### Features * add service details to EM UI ([#1352](#1352)) ([2ccd98d](2ccd98d)) * added ability to lint Starlark packages ([#1360](#1360)) ([f4a072c](f4a072c)), closes [#1228](#1228) * Support YAML as Package param ([#1350](#1350)) ([e33bfe6](e33bfe6)) ### Bug Fixes * tail logs from end of log file ([#1339](#1339)) ([b8d5816](b8d5816)) * warn instead of failing for json log line parse error ([#1336](#1336)) ([44b2820](44b2820)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Occassionally, we hit a race condition between the
LogsAggregatorwriting a log line whileservice logsis reading and streaming log files. This results in a half written json log line being read while streaming logs and a parsing error to occur. Instead of failing immediately, this PR logs aWarninstead and continues to read the log file.Is this change user facing?
YES