fix: warn instead of failing for json log line parse error #1336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Occassionally, we hit a race condition between the
LogsAggregator
writing a log line whileservice logs
is reading and streaming log files. This results in a half written json log line being read while streaming logs and a parsing error to occur. Instead of failing immediately, this PR logs aWarn
instead and continues to read the log file.Is this change user facing?
YES