Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative import breaks for 'non-main branchs' #1361

Closed
leoporoli opened this issue Sep 21, 2023 · 0 comments · Fixed by #1364 or #1379
Closed

Relative import breaks for 'non-main branchs' #1361

leoporoli opened this issue Sep 21, 2023 · 0 comments · Fixed by #1364 or #1379
Assignees
Labels
bug Something isn't working painful Painful bug

Comments

@leoporoli
Copy link
Contributor

What's your CLI version?

0.83.2

Description & steps to reproduce

I modified the avalanche package to use relative locators, here are the changes, if we run this package locally it works but if we run the package using the “branch” it fails, it seems the relative import fails on this case. You can tes it by doing this kurtosis run [github.com/kurtosis-tech/avalanche-package@lporoli/local-absolute-locators

it’s the issue:
There was an error interpreting Starlark code

Evaluation error: An error occurred while loading the module 'github.com/src/node_launcher.star'
        Caused by: The path 'github.com/src/node_launcher.star' needs to point to a specific file but it didn't. Users can only read or import specific files and not entire packages.
        at [github.com/kurtosis-tech/avalanche-package@lporoli/local-absolute-locators/main.star:1:30]: <toplevel>
        
Error encountered running Starlark code.

if you pay attention to this github.com/src/node_launcher.star it seems that the loader is removing the /kurtosis-tech/avalanche-package from the path.

Desired behavior

kurtosis run github.com/kurtosis-tech/avalanche-package@lporoli/local-absolute-locators should work

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.

@leoporoli leoporoli added the bug Something isn't working label Sep 21, 2023
@github-actions github-actions bot added the painful Painful bug label Sep 21, 2023
@leoporoli leoporoli self-assigned this Sep 21, 2023
leoporoli added a commit that referenced this issue Sep 26, 2023
## Description:
Relative import breaks for 'non-main branchs'

## Is this change user-facing?
NO

## References (if applicable):
fix #1361
adschwartz added a commit that referenced this issue Sep 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.83.8](0.83.7...0.83.8)
(2023-09-26)


### Bug Fixes

* Relative import breaks for 'non-main branchs'
([#1364](#1364))
([5496082](5496082)),
closes [#1361](#1361)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: Anders Schwartz <adschwartz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working painful Painful bug
Projects
None yet
1 participant