Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Docker socket to be configured as an optional parameter to the docker-type blocks in the config #1469

Open
mieubrisse opened this issue Oct 4, 2023 · 0 comments
Labels

Comments

@mieubrisse
Copy link
Member

mieubrisse commented Oct 4, 2023

Background & motivation

To solve #1072 and #1140 , #1362 was implemented.

However, this is hacky: it requires setting a magic DOCKER_HOST environment variable, which the user needs to know exist. Additionally, it means that Kurtosis is no longer self-contained: it will be reading an environment variable that the user may or may not have set (and the user needs to set in their .bashrc).

Desired behaviour

Kurtosis should be completely self-contained, meaning all Kurtosis settings are read from Kurtosis configs, and the Docker socket should be configurable in the Kurtosis config file. Kurtosis should not read the DOCKER_HOST environment variable.

Kurotsis' new preference algorithm should be:

  1. Use the socket set in the config block as detailed in Support DOCKER_HOST environment variable #1072 (comment)
  2. Use the system wide docker socket /var/run/docker.sock if it exists
  3. Use the user docker socket ${HOME}/.docker/run/docker.sock if it exists
  4. Fallback to docker.FromEnv

Additionally, we have docs on how to set this in the Kurtosis config file.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

@github-actions github-actions bot added the painful Painful bug label Oct 4, 2023
@mieubrisse mieubrisse removed their assignment Oct 11, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
## Description:
This PR adds a small note in the Kurtosis installation docs about a
common bug that we've come across where `unix:///var/run/docker.sock`
wasn't found.

## Is this change user facing?
YES

## References (if applicable):
#1140, #1072, and #1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant