Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cli argument to control image download #1495

Merged
merged 27 commits into from Oct 28, 2023
Merged

feat: Add cli argument to control image download #1495

merged 27 commits into from Oct 28, 2023

Conversation

lostbean
Copy link
Contributor

@lostbean lostbean commented Oct 6, 2023

Description:

This PR adds a new cli argument to control how to download the latest images.

Is this change user facing?

YES

References (if applicable):

This PR is aimed to address #1299

@leeederek
Copy link
Contributor

Hey @lostbean and @tedim52:

  1. Can we make sure we have docs for this new flag in the run starlark reference?
  2. I saw in a doc that there was an ownership transfer that took place - can the correct owner be reassigned on the parent issue? Allow offline mode with local images #1299

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 19, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70d5ce7
Status: ✅  Deploy successful!
Preview URL: https://246957bb.kurtosis-docs.pages.dev
Branch Preview URL: https://edgar-image-download-flag.kurtosis-docs.pages.dev

View logs

@lostbean
Copy link
Contributor Author

Hey @lostbean and @tedim52:

  1. Can we make sure we have docs for this new flag in the run starlark reference?
  2. I saw in a doc that there was an ownership transfer that took place - can the correct owner be reassigned on the parent issue? Allow offline mode with local images #1299

@leeederek the issue is already assigned to me and I just updated the documentation to include the new flag.

@lostbean lostbean requested a review from tedim52 October 19, 2023 02:37
tedim52
tedim52 requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tedim52 tedim52 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good, functionality is definitely there, jus requesting some changes around how we're representing image download mode to follow existing patterns in the codebase

tedim52
tedim52 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for addressing comments, last thing is magic constant comment and then good to merge!

@lostbean lostbean added this pull request to the merge queue Oct 28, 2023
@lostbean lostbean mentioned this pull request Oct 28, 2023
Closed
Merged via the queue into main with commit f210a76 Oct 28, 2023
34 checks passed
@lostbean lostbean deleted the edgar/image-download-flag branch October 28, 2023 20:38
@kurtosisbot kurtosisbot mentioned this pull request Oct 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@kurtosisbot @leoporoli
chore(main): release 0.85.0 (#1645)
ad04e1f 
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](0.84.13...0.85.0)
(2023-10-30)


### ⚠ BREAKING CHANGES

* protobuf definitions for more idiomatic SDKs
([#1586](#1586))

### Features

* Add cli argument to control image download
([#1495](#1495))
([f210a76](f210a76))


### Bug Fixes

* run_sh doesn't remove new lines from input
([#1642](#1642))
([a969dff](a969dff))


### Code Refactoring

* protobuf definitions for more idiomatic SDKs
([#1586](#1586))
([e7ab58a](e7ab58a)),
closes [#843](#843)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: leoporoli <leandroporoli@gmail.com>
@lostbean lostbean mentioned this pull request Oct 30, 2023
Merged
h4ck3rk3y pushed a commit that referenced this pull request Oct 31, 2023
@kurtosisbot @leoporoli @h4ck3rk3y
chore(main): release 0.85.0 (#1645)
67e19e9 
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](0.84.13...0.85.0)
(2023-10-30)


### ⚠ BREAKING CHANGES

* protobuf definitions for more idiomatic SDKs
([#1586](#1586))

### Features

* Add cli argument to control image download
([#1495](#1495))
([f210a76](f210a76))


### Bug Fixes

* run_sh doesn't remove new lines from input
([#1642](#1642))
([a969dff](a969dff))


### Code Refactoring

* protobuf definitions for more idiomatic SDKs
([#1586](#1586))
([e7ab58a](e7ab58a)),
closes [#843](#843)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: leoporoli <leandroporoli@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@lostbean @leeederek
fix: Improve description of the image-download flag (#1660)
230b4d0 
## Description:
Improve description of the image-download flag in both CLI help and
docs.

## Is this change user facing?
YES

## References (if applicable):
- fix on #1495 for #1299

---------

Co-authored-by: Derek <103802618+leeederek@users.noreply.github.com>
@leeederek leeederek mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedim52 tedim52 tedim52 approved these changes

Assignees
No one assigned
Labels
user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lostbean @leeederek @tedim52