Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cli argument to control image download #1495

Merged
merged 27 commits into from Oct 28, 2023
Merged

feat: Add cli argument to control image download #1495

merged 27 commits into from Oct 28, 2023

Commits on Oct 19, 2023

  1. Add image pulling mode to docker manager

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    2b8a14e View commit details
    Browse the repository at this point in the history

  2. swap inverted defaults

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    045551b View commit details
    Browse the repository at this point in the history

  3. Add CLI argument to capture image download mode

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    cf38e01 View commit details
    Browse the repository at this point in the history

  4. Add image download mode to API

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    66ab73e View commit details
    Browse the repository at this point in the history

  5. Updating the correct abstraction - KurtosisBackend

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    3f86ebf View commit details
    Browse the repository at this point in the history

  6. Apply image download mode via validator

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    556107f View commit details
    Browse the repository at this point in the history

  7. make API type safe

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    4f99e61 View commit details
    Browse the repository at this point in the history

  8. remove duplicated enum definition

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    ba6e70c View commit details
    Browse the repository at this point in the history

  9. Move switch case to a common location

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    0c5105a View commit details
    Browse the repository at this point in the history

  10. Correct flag message

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    6434b1e View commit details
    Browse the repository at this point in the history

  11. rename file

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    8cd67a3 View commit details
    Browse the repository at this point in the history

  12. Actually genarate code using enumer

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    c59972a View commit details
    Browse the repository at this point in the history

  13. pass image download mode to fetchImageFromBackend

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    d3d2887 View commit details
    Browse the repository at this point in the history

  14. fix RPC translator

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    7f36410 View commit details
    Browse the repository at this point in the history

  15. Log mode when fetching image

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    eee5e3d View commit details
    Browse the repository at this point in the history

  16. Remove unimplemented flag 'never'

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    24124f2 View commit details
    Browse the repository at this point in the history

  17. Fix wrong removal

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    6fef551 View commit details
    Browse the repository at this point in the history

  18. Document new flag --image-download

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    c931780 View commit details
    Browse the repository at this point in the history

  19. remove never enum from protobuf

    @lostbean
    lostbean committed Oct 19, 2023
    Copy the full SHA
    563798c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. do not return value if fail to parse

    @lostbean
    lostbean committed Oct 20, 2023
    Copy the full SHA
    1971a1b View commit details
    Browse the repository at this point in the history

  2. rename functions for clarity and consistency

    @lostbean
    lostbean committed Oct 20, 2023
    Copy the full SHA
    e77cbd7 View commit details
    Browse the repository at this point in the history

  3. remove intermediary data structure to simplify codebase

    @lostbean
    lostbean committed Oct 20, 2023
    Copy the full SHA
    198a4dd View commit details
    Browse the repository at this point in the history

  4. moving conversion func to apic

    @lostbean
    lostbean committed Oct 20, 2023
    Copy the full SHA
    d7b08ea View commit details
    Browse the repository at this point in the history

  5. rename args to match CamelCase format

    @lostbean
    lostbean committed Oct 20, 2023
    Copy the full SHA
    c957ccf View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. no magic and early ejection

    @lostbean
    lostbean committed Oct 25, 2023
    Copy the full SHA
    a079a35 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into edgar/image-download-flag

    @lostbean
    lostbean committed Oct 25, 2023
    Copy the full SHA
    82e18e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge branch 'main' into edgar/image-download-flag

    @lostbean
    lostbean committed Oct 27, 2023
    Copy the full SHA
    70d5ce7 View commit details
    Browse the repository at this point in the history