Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kurtosis clean (without -a) remove old engine images #1523

Closed
mieubrisse opened this issue Oct 11, 2023 · 0 comments · Fixed by #1551 or #1555
Closed

Make kurtosis clean (without -a) remove old engine images #1523

mieubrisse opened this issue Oct 11, 2023 · 0 comments · Fixed by #1551 or #1555
Labels
feature request nice to have Nice to have feature

Comments

@mieubrisse
Copy link
Member

Background & motivation

The -a flag on clean is explicitly for removing enclaves that are still running. It's also been coopted so that when passed it removes old images. This means that users have an option to NOT remove old engine images, which actually isn't behaviour I want to promote (Kurtosis should by default clean up after itself).

Desired behaviour

Vanilla kurtosis clean (even without -a) removes old engine/core images

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.
@github-actions github-actions bot added the nice to have Nice to have feature label Oct 11, 2023
@victorcolombo victorcolombo mentioned this issue Oct 13, 2023
Merged
victorcolombo added a commit that referenced this issue Oct 13, 2023
@victorcolombo
Merge branch 'main' into vcolombo/gh-1523
c864917
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@victorcolombo
feat: Unused images are cleaned even without -a flag (#1551)
e1317aa 
## Description:
<!-- Describe this change, how it works, and the motivation behind it.
-->

## Is this change user facing?
YES
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1523
@kurtosisbot kurtosisbot mentioned this issue Oct 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@kurtosisbot
chore(main): release 0.84.6 (#1555)
f551317 
🤖 I have created a release *beep* *boop*
---


##
[0.84.6](0.84.5...0.84.6)
(2023-10-13)


### Features

* Unused images are cleaned even without -a flag
([#1551](#1551))
([e1317aa](e1317aa)),
closes [#1523](#1523)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request nice to have Nice to have feature
Projects
None yet
Milestone
No milestone
1 participant
@mieubrisse