Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named files artifact for run_sh #1581

Closed
barnabasbusa opened this issue Oct 18, 2023 · 0 comments · Fixed by #1608 or #1609
Closed

Named files artifact for run_sh #1581

barnabasbusa opened this issue Oct 18, 2023 · 0 comments · Fixed by #1608 or #1609
Assignees
Labels
cli For bugs relating to the CLI feature request nice to have Nice to have feature

Comments

@barnabasbusa
Copy link
Contributor

Background & motivation

It would be great if the output of a run_sh could be stored in a named global files artifact.

Something like this:

    genesis_validators_root = plan.run_sh(
        run="cat /data/data/custom_config_data/genesis_validators_root.txt",
        image="busybox",
        files={"/data": genesis.files_artifacts[0]},
        wait=None,    )
        artifact.name = "whatever" 
        artifact.content = genesis_validators_root.output
        return artifact

Desired behaviour

Currently the only way to get the artifact out of a run_sh instruction is by creating a new struct for it, and you will have to refer to it as a uuid instead of the artifact name.

def new_el_cl_genesis_data(
    files_artifact_uuid,
    genesis_validators_root,
):
    return struct(
        files_artifact_uuid=files_artifact_uuid,
        genesis_validators_root=genesis_validators_root,
    )

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.

What area of the product does this pertain to?

CLI: the Command Line Interface

@github-actions github-actions bot added cli For bugs relating to the CLI nice to have Nice to have feature labels Oct 18, 2023
@h4ck3rk3y h4ck3rk3y self-assigned this Oct 19, 2023
@h4ck3rk3y h4ck3rk3y self-assigned this Oct 24, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2023
## Description:
Allows for named artifact creation via `StoreSpec`

Left

- [x] Clean the code
- [x] Fix the docs

## Is this change user facing?
YES

## References (if applicable):
Closes #1581
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.11](0.84.10...0.84.11)
(2023-10-24)


### Features

* add full story script
([#1610](#1610))
([de10c7b](de10c7b))
* allow for named artifact creation in run_sh and run_python
([#1608](#1608))
([1a9d953](1a9d953)),
closes [#1581](#1581)
* disable smooth scrolling for logs and default to select restart
services
([#1612](#1612))
([2ee86c4](2ee86c4))


### Bug Fixes

* clean em api get service logs streaming logic
([#1589](#1589))
([f8d8bda](f8d8bda))
* show container status instead of service status in UI
([#1567](#1567))
([4b75980](4b75980))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli For bugs relating to the CLI feature request nice to have Nice to have feature
Projects
None yet
2 participants