feat: warn users of diff architecture image running #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its basically this but I don't log the architecture in the initial blue message any more - that was just for test |
h4ck3rk3y
force-pushed
the
gyani/platform
branch
from
aa0ae86
to
185561f
Compare
Deploying with
|
| Latest commit: |
185561f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a1dc7e41.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gyani-platform.kurtosis-docs.pages.dev |
h4ck3rk3y
force-pushed
the
gyani/platform
branch
from
cbdb6b1
to
0243865
Compare
leoporoli
reviewed
Oct 31, 2023
leoporoli
approved these changes
Oct 31, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.1](0.85.0...0.85.1) (2023-10-31) ### Features * initial new enclave manager ([#1603](#1603)) ([9944658](9944658)) * warn users of diff architecture image running ([#1649](#1649)) ([77f2f69](77f2f69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We now warn users in the beginning if the image is different from whats expected
Is this change user facing?
YES/NO
References (if applicable):