feat: initial new enclave manager #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
reviewed
Oct 23, 2023
|
One more thing: can you add a build script (put it under |
Dartoxian
commented
Oct 26, 2023
|
Thanks for the extra comments and chatting last night @adschwartz . I've updated this PR with all of the feedback we discussed to change now. I'm going to go through the design changes now in a fresh branch from this one. |
## Description: This PR primarily adds support for the new enclave view to the enclave manager, and picks up changes to the design of components. Significant changes: * The enclave view is added * Theming has been updated to match the mocks. Now that I've taken a few look over the mocks and am more familiar with which components are special and which are common, where possible I've shifted to overriding existing chakra styles rather than defining new ones for the brand * The breadcrumb logic will now be used across the application, rather than custom for enclaves (catalog etc) * React router is used properly to load data, rather than loading in effects. In order to provide the `kurtosisClient` to react router - which can only be provided after initial render - the `createBrowserRouter` is moved around a little to live inside the new `KurtosisRouteProvider` instead. ### Feedback required: * The mocks include container started times. I think the api needs to have this added * The mocks include file descriptions - is this actually stored? How can it be obtained * The port summary overview is not in the mocks - my implementation is likely poorly designed. * Is there an empty state for tables that can be used? ### Demo https://github.com/kurtosis-tech/kurtosis/assets/4419574/192240bd-6cbf-4a69-9c7f-072783fd965e ## Is this change user facing? NO (This is not yet in the deploy process) ## References (if applicable): This PR is based on top of #1603 which should be merged first. --------- Co-authored-by: Anders Schwartz <anders.schwartz@kurtosistech.com>
adschwartz
approved these changes
Oct 30, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.1](0.85.0...0.85.1) (2023-10-31) ### Features * initial new enclave manager ([#1603](#1603)) ([9944658](9944658)) * warn users of diff architecture image running ([#1649](#1649)) ([77f2f69](77f2f69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains the beginnings of the new enclave manager ui. Specifically it adds a new project in
enclave-manager/web. Notable inclusions:useKurtosisClientby theKurtosisClientProvider. This provider blocks loading the application (with a spinner) until it's configured the client to use.Demo (WIP)
kurtosisBones.mp4
Is this change user facing?
NO (this is not yet part of the build/deploy process)
References (if applicable):
This PR is rebased on top of #1595 which should be merged first.