Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The stop enclave CLI command is not updating the service status in the service registration repository #1711

Closed
leoporoli opened this issue Nov 7, 2023 · 0 comments · Fixed by #1712 or #1724
Closed

The stop enclave CLI command is not updating the service status in the service registration repository #1711

leoporoli opened this issue Nov 7, 2023 · 0 comments · Fixed by #1712 or #1724
Labels
bug Something isn't working cli For bugs relating to the CLI papercut

Comments

@leoporoli
Copy link
Contributor

leoporoli commented Nov 7, 2023 •
edited

What's your CLI version?

0.85.1

Description & steps to reproduce

The kurtosis enclave stop {enclave-identifier} kill all the container in the Docker backend but this workflow doesn't unregister the user services in the user service registration repository

Desired behavior

It should update the service status to "stop" in the service registration repository because otherwise we will have conflicts if we want to restart the services

What is the severity of this bug?

Papercut; this bug is frustrating, but I have a workaround.

What area of the product does this pertain to?

CLI: the Command Line Interface
@leoporoli leoporoli added the bug Something isn't working label Nov 7, 2023
@github-actions github-actions bot added cli For bugs relating to the CLI papercut labels Nov 7, 2023
@leoporoli leoporoli mentioned this issue Nov 7, 2023
Merged
@leoporoli leoporoli changed the title The stop enclave CLI command is not unregistering the services The stop enclave CLI command is not updating the service status in the service registration repository Nov 8, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2023
@leoporoli
fix: stop all services first to update the service status in the serv…
3d1e142 
…ice registration during a `kurtosis enclave stop` execution (#1712)

## Description:
unregister the enclave services during a `kurtosis enclave stop`
execution

## Is this change user-facing?
NO

## References (if applicable):
Fix #1711
@kurtosisbot kurtosisbot mentioned this issue Nov 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2023
@kurtosisbot
chore(main): release 0.85.8 (#1724)
ef79fe2 
🤖 I have created a release *beep* *boop*
---


##
[0.85.8](0.85.7...0.85.8)
(2023-11-08)


### Features

* support downloading artifacts in the new emui
([#1720](#1720))
([fbfeaa3](fbfeaa3))


### Bug Fixes

* stop all services first to update the service status in the service
registration during a `kurtosis enclave stop` execution
([#1712](#1712))
([3d1e142](3d1e142)),
closes [#1711](#1711)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cli For bugs relating to the CLI papercut
Projects
None yet
Milestone
No milestone
1 participant
@leoporoli