feat: new emui use monaco as json editor #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Nov 9, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.10](0.85.9...0.85.10) (2023-11-09) ### Features * add download artifacts endpoint to enclave manager ([#1730](#1730)) ([3909d5c](3909d5c)) * improve logging part 1 ([#1728](#1728)) ([8f631ae](8f631ae)) * new emui use monaco as json editor ([#1733](#1733)) ([298a0a2](298a0a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR switches to using the monaco editor for json input. I've changed the layout functionality to effectively match the previous
CodeEditor.js- which seems to work for me, though I can't explain why callinglayouttwice (or so frequently) is necessary.This PR also fixes the use of the Inter font
Additionally this PR fixes several pieces of feedback from Tise:
x selectedhover interactivityDemo
monacoEditor.mp4
Is this change user facing?
YES