Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud: unable to find all occurrences of searched item in logs #1791

Closed
barnabasbusa opened this issue Nov 14, 2023 · 4 comments · Fixed by #1830 or #1836
Closed

Cloud: unable to find all occurrences of searched item in logs #1791

barnabasbusa opened this issue Nov 14, 2023 · 4 comments · Fixed by #1830 or #1836
Assignees
@adschwartz
Labels
bug Something isn't working critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend

Comments

@barnabasbusa
Copy link
Contributor

What's your CLI version?

N/A

Description & steps to reproduce

When I try to find a certain log entry in https://cloud.kurtosis.com/enclave-manager/enclave/66a897a354f1/service/151acad62d58/logs I can't seem to find all occurrences of searched object with cmd+f.

Desired behavior

Would be good to either include a search box in the logs tab, or enable me to search the whole logs file with cmd+f.

What is the severity of this bug?

Critical; I am blocked and Kurtosis is unusable for me because of this bug.

What area of the product does this pertain to?

Frontend: the Graphical User Interface, including the Enclave Manager
@barnabasbusa barnabasbusa added the bug Something isn't working label Nov 14, 2023
@github-actions github-actions bot added critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend labels Nov 14, 2023
@mieubrisse
Copy link
Member

Hey @barnabasbusa thanks for filing! The way the frontend currently works is that it loads the first couple thousand (I believe it's 2k) loglines and then cmd-f will operate on that. Is the logline you're looking for from beyond the first 2k lines? Or, is the bug related to a match that you're seeing in the frontend not getting matched?

@mieubrisse
Copy link
Member

Repro'd with Barnabas - the search terms that are loaded in the frontend, but not immediately visible, aren't getting matched:

Screen Shot 2023-11-15 at 13 52 45

@adschwartz
Copy link
Contributor

it appears that when you search it only highlights what's in the viewable port. Seems to be a limitation with react-virtuoso? virtuoso doesn't seem to have any native search capabilities. @Dartoxian may be we'll need a custom search function?

@Dartoxian
Copy link
Contributor

yep I think you're right @adschwartz . I think it would be reasonable to intercept ctrl+f and provide search capability in the log view, then control scrolling react-virtuoso ourselves to navigate results..

@adschwartz adschwartz mentioned this issue Nov 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 20, 2023
@adschwartz
feat: search in service logs (#1830)
7fce5b5 
## Description:
Adding a search bar to the service logs window

![image](https://github.com/kurtosis-tech/kurtosis/assets/11248996/60f962af-743d-49a4-87d5-74e2f02fed82)


## Is this change user facing?
YES
## References (if applicable):
Closes #1791
@kurtosisbot kurtosisbot mentioned this issue Nov 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 20, 2023
@kurtosisbot
chore(main): release 0.85.33 (#1836)
1be17e3 
🤖 I have created a release *beep* *boop*
---


##
[0.85.33](0.85.32...0.85.33)
(2023-11-20)


### Features

* search in service logs
([#1830](#1830))
([7fce5b5](7fce5b5)),
closes [#1791](#1791)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adschwartz adschwartz

Labels
bug Something isn't working critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend
Projects
None yet
Milestone
No milestone
4 participants
@mieubrisse @Dartoxian @adschwartz @barnabasbusa