feat: add production mode to k8s #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8447820.
Deploying with
|
| Latest commit: |
08e74bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74c5e3fe.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gyani-production.kurtosis-docs.pages.dev |
This reverts commit 1d918c0.
h4ck3rk3y
commented
Dec 15, 2023
| apiContainerContainers, apiContainerVolumes, err := getApiContainerContainersAndVolumes(image, containerPorts, envVarsWithOwnIp, enclaveDataVolumeDirpath) | ||
| if err != nil { | ||
| return nil, stacktrace.Propagate(err, "An error occurred getting API containers and volumes") | ||
| } | ||
|
|
||
| apiContainerInitContainers := []apiv1.Container{} | ||
|
|
||
| // Data is always persistent we can always restart like Docker | ||
| apiContainerRestartPolicy := apiv1.RestartPolicyOnFailure |
There was a problem hiding this comment.
@leoporoli Questions here -
This is very similar to what Docker does; and docker always has persistent volume for /kurtosis-data but on Kubernetes that adds time on DO/AWS; on k3s it seems like no time is added
There was a problem hiding this comment.
we talked about this on Slack and I agree with adding this for all enclaves so far.
leoporoli
approved these changes
Dec 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.49](0.85.48...0.85.49) (2023-12-18) ### Features * add production mode to k8s ([#1963](#1963)) ([b0e27e6](b0e27e6)) * persistent volumes work on multi node k8s clusters ([#1943](#1943)) ([b2fd9f2](b2fd9f2)) * User service K8S ingresses for reverse proxy routing ([#1941](#1941)) ([c37dd7f](c37dd7f)) ### Bug Fixes * adding remove logs aggregator container function when it already exists ([#1974](#1974)) ([5d74d16](5d74d16)) * Do not fail if the Traefik config dir path already exists ([#1966](#1966)) ([4e6f7d7](4e6f7d7)) * ignore the current status of the service during a start/stop ([#1965](#1965)) ([1c4863f](1c4863f)) * refactor the emui components to the shared package ([#1959](#1959)) ([a406973](a406973)) * Set the user service K8S ingress labels so it can be found ([#1962](#1962)) ([9cc5f77](9cc5f77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: leoporoli <leandroporoli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Is this change user facing?
YES