-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add production mode to k8s #1963
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
614013d
cascading storage class changes
h4ck3rk3y fdfe9f7
added some docs
h4ck3rk3y 3c840fa
apic has storage class stuff now
h4ck3rk3y 2ee34a4
remove some dupes
h4ck3rk3y bd2117c
remove apic launcher change
h4ck3rk3y 592755c
get rid of some more functions
h4ck3rk3y 2ea0a01
fix missing struct value
h4ck3rk3y e9e31d1
fix changelog image building pr
h4ck3rk3y 8980073
Merge branch 'main' into gyani/storage-class
h4ck3rk3y 5e8e7a3
feat: allow specifying size of persistent directories (#1939)
h4ck3rk3y 9d91c26
claim -> volume
h4ck3rk3y 03e436a
fix ci
h4ck3rk3y a59a366
dev stuff, do revert
h4ck3rk3y 3e912df
fix constant volume szie
h4ck3rk3y c260fa7
added back funciton
h4ck3rk3y f45cde3
--amend
h4ck3rk3y 438c5a1
Revert "dev stuff, do revert"
h4ck3rk3y acb5a1f
Merge branch 'main' into gyani/persistent-volumes
h4ck3rk3y 55db506
Revert "Revert "dev stuff, do revert""
h4ck3rk3y ae64ac5
Revert "Revert "Revert "dev stuff, do revert"""
h4ck3rk3y 5709553
better k3s instructions
h4ck3rk3y 62e4d63
added a note on deletion
h4ck3rk3y 722f7ca
remove unused code
h4ck3rk3y 3bcb536
remove unused variable
h4ck3rk3y a8b338e
added a restart policy
h4ck3rk3y d435280
added restart policy to a few more places
h4ck3rk3y 0f7e441
remove unused label
h4ck3rk3y a6abe07
this should build
h4ck3rk3y 8447820
Revert "Revert "Revert "Revert "dev stuff, do revert""""
h4ck3rk3y b48d44c
this should build
h4ck3rk3y 8faccc0
fix docs
h4ck3rk3y 7cbc65a
Revert "Revert "Revert "Revert "Revert "dev stuff, do revert"""""
h4ck3rk3y c75d49f
fix linter
h4ck3rk3y 1d918c0
production mode governs whether APIC has persistent data or not
h4ck3rk3y 54001cf
work based on fragment + enclave-id
h4ck3rk3y 4692e9a
Revert "production mode governs whether APIC has persistent data or not"
h4ck3rk3y 7f4ceb4
make restart policy on failure always as volume is always persistent
h4ck3rk3y 80a30de
Merge branch 'main' into gyani/production
h4ck3rk3y 981554c
Merge branch 'main' into gyani/production
h4ck3rk3y 08e74bb
fix config
h4ck3rk3y File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leoporoli Questions here -
This is very similar to what Docker does; and docker always has persistent volume for
/kurtosis-data
but on Kubernetes that adds time on DO/AWS; on k3s it seems like no time is addedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we talked about this on Slack and I agree with adding this for all enclaves so far.