Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename imageregistryspec to imagespec #2189

Closed
h4ck3rk3y opened this issue Feb 19, 2024 · 0 comments · Fixed by #2191 or #2175
Closed

rename imageregistryspec to imagespec #2189

h4ck3rk3y opened this issue Feb 19, 2024 · 0 comments · Fixed by #2191 or #2175
Assignees
Labels

Comments

@h4ck3rk3y
Copy link
Contributor

Background & motivation

registry is a detail, all strings should just become imagespec

Desired behaviour

imagregistryspec -> imagespec

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

Other: anything not covered by the above

@h4ck3rk3y h4ck3rk3y self-assigned this Feb 19, 2024
@github-actions github-actions bot added the painful Painful bug label Feb 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2024
this is cleaner; registry is an implementation detail that the end
person doesn't care about

Closes #2189
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.87.0](0.86.25...0.87.0)
(2024-02-20)


### ⚠ BREAKING CHANGES

* change registry spec to imagespec
([#2191](#2191))

### Features

* change registry spec to imagespec
([#2191](#2191))
([bc20d51](bc20d51)),
closes [#2189](#2189)


### Bug Fixes

* change default verbosity to description
([#2173](#2173))
([d3b3de9](d3b3de9))
* improved some descriptions for starlark instructions
([#2168](#2168))
([d7fdbc5](d7fdbc5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant