Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed the error we see while running the package(s) in dry-mode #679

Merged
merged 3 commits into from Jun 7, 2023
Merged

fix: fixed the error we see while running the package(s) in dry-mode #679

merged 3 commits into from Jun 7, 2023

Conversation

Peeeekay
Copy link
Contributor

@Peeeekay Peeeekay commented Jun 5, 2023 •
edited

@Peeeekay Peeeekay requested a review from h4ck3rk3y June 5, 2023 22:27
h4ck3rk3y
h4ck3rk3y approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peeeekay Peeeekay merged commit af5138c into main Jun 7, 2023
27 checks passed
@Peeeekay Peeeekay deleted the pk/fix_dry_mode_error branch June 7, 2023 04:57
@kurtosisbot kurtosisbot mentioned this pull request Jun 7, 2023
Merged
victorcolombo pushed a commit that referenced this pull request Jun 8, 2023
@kurtosisbot
chore(main): release 0.77.2 (#659)
4b3f538 
🤖 I have created a release *beep* *boop*
---


##
[0.77.2](0.77.1...0.77.2)
(2023-06-08)


### Features

* added min resource constraint for kubernetes
([#687](#687))
([0aadb91](0aadb91))
* Label issue based on severity
([#662](#662))
([13b51c6](13b51c6))


### Bug Fixes

* Auto-restart engine when cluster is updated
([#661](#661))
([479b9f4](479b9f4))
* display service name in exec
([#682](#682))
([6faafea](6faafea))
* Fix error propagation in context switch
([#658](#658))
([a7c9bd1](a7c9bd1))
* Fix typo in the configuration path of the issue labeler workflow
([#667](#667))
([ec6c8e8](ec6c8e8))
* Fix user service logs when backend is kubernetes
([#678](#678))
([099d046](099d046))
* fixed the error we see while running the package(s) in dry-mode
([#679](#679))
([af5138c](af5138c))
* Kurtosis shell exec panics if stdin is not terminal
([#686](#686))
([5fad486](5fad486))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4ck3rk3y h4ck3rk3y h4ck3rk3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Peeeekay @h4ck3rk3y