Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed the error we see while running the package(s) in dry-mode #679

Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix: fixed the error we see while running the package(s) in dry-mode #679

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c68cfd7
fix: fixed the error we see while running the package(s) in dry-mode
Peeeekay Jun 5, 2023
8cc7027
Merge branch 'main' into pk/fix_dry_mode_error
Peeeekay Jun 5, 2023
dc3a3d7
Merge branch 'main' into pk/fix_dry_mode_error
Peeeekay Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions core/server/api_container/server/startosis_engine/startosis_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,17 @@ func (executor *StartosisExecutor) Execute(ctx context.Context, dryRun bool, par
}
}

scriptWithValuesReplaced, err := magic_string_helper.ReplaceRuntimeValueInString(serializedScriptOutput, executor.runtimeValueStore)
if err != nil {
propagatedErr := stacktrace.Propagate(err, "An error occurred while replacing the runtime values in the output of the script")
serializedError := binding_constructors.NewStarlarkExecutionError(propagatedErr.Error())
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromExecutionError(serializedError)
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromRunFailureEvent()
return
if !dryRun {
Peeeekay marked this conversation as resolved.
Show resolved Hide resolved
scriptWithValuesReplaced, err := magic_string_helper.ReplaceRuntimeValueInString(serializedScriptOutput, executor.runtimeValueStore)
if err != nil {
propagatedErr := stacktrace.Propagate(err, "An error occurred while replacing the runtime values in the output of the script")
serializedError := binding_constructors.NewStarlarkExecutionError(propagatedErr.Error())
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromExecutionError(serializedError)
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromRunFailureEvent()
return
}
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromRunSuccessEvent(scriptWithValuesReplaced)
}
starlarkRunResponseLineStream <- binding_constructors.NewStarlarkRunResponseLineFromRunSuccessEvent(scriptWithValuesReplaced)
}()
return starlarkRunResponseLineStream
}