New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added min/max cpu and memory for kubernetes via starlark #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeeekay
force-pushed
the
pk/add_min_resource_kubernetes
branch
from
June 8, 2023 05:01
067a36a
to
b8c9a5f
Compare
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 8, 2023 05:32
315694e
to
b9bedec
Compare
Peeeekay
changed the title
Pk/propagate min to starlark
feat: added min/max cpu and memory for kubernetes via starlark
Jun 8, 2023
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 8, 2023 16:32
3b17a8e
to
081bf56
Compare
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 9, 2023 01:34
9cfae4d
to
7b5271f
Compare
Sample Starlark
Result:
|
Sample Starlark:
|
laurentluce
reviewed
Jun 9, 2023
api/typescript/src/core/kurtosis_core_rpc_api_bindings/api_container_service_grpc_web_pb.js
Outdated
Show resolved
Hide resolved
...osis_engine/kurtosis_starlark_framework/test_engine/service_config_full_framework_bc_test.go
Outdated
Show resolved
Hide resolved
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 12, 2023 00:05
e35706c
to
9d4569a
Compare
laurentluce
approved these changes
Jun 12, 2023
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 12, 2023 19:01
9127473
to
074d6da
Compare
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
2 times, most recently
from
June 13, 2023 05:55
3aa9e54
to
655cf52
Compare
Peeeekay
force-pushed
the
pk/propagate_min_to_starlark
branch
from
June 13, 2023 06:01
655cf52
to
711b09b
Compare
adschwartz
pushed a commit
that referenced
this pull request
Jun 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.78.1](0.78.0...0.78.1) (2023-06-13) ### Features * added min/max cpu and memory for kubernetes via starlark ([#689](#689)) ([faffc07](faffc07)) * use kurtosis service name as the kubernetes service name ([#713](#713)) ([b0d6b8e](b0d6b8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
neat stuff :) Will use! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the doc PR with relevant description: #708