feat: added minimum resources for containers on k8s to the docs. #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeeekay
changed the title
Deploying with
|
| Latest commit: |
caeb619
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e4b53881.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://pk-add-min-max-to-docs.kurtosis-docs.pages.dev |
laurentluce
approved these changes
Jun 12, 2023
Peeeekay
added a commit
that referenced
this pull request
Jun 13, 2023
Here is the doc PR with relevant description: #708
Peeeekay
force-pushed
the
pk/add_min_max_to_docs
branch
from
4b3f275
to
488259b
Compare
leoporoli
pushed a commit
that referenced
this pull request
Jun 13, 2023
Updated the docs for: Users can add min resource requirements for their containers on Kubernetes and update the doc accordingly. Along with that, we are replacing `cpu_allocation` and `memory_allocation` with `max_cpu` and `max_memory` fields in ServiceConfig. We will deprecate `cpu_allocation` and `memory_allocation` in two weeks from now. An example to set resources: ``` ServiceConifg( ..., max_cpu = 1000, min_cpu = 500, max_memory = 1024, min_memory = 512, ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the docs for:
Users can add min resource requirements for their containers on Kubernetes and update the doc accordingly. Along with that, we are replacing
cpu_allocationandmemory_allocationwithmax_cpuandmax_memoryfields in ServiceConfig.We will deprecate
cpu_allocationandmemory_allocationin two weeks from now. An example to set resources: