feat: Starlark package arguments will be parsed as a deep Struct when "_kurtosis_parser": "struct" is passed in the arguments JSON
#884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
changed the title
"_kurtosis_parser": "struct" is passed in the arguments JSON"_kurtosis_parser": "struct" is passed in the arguments JSON
gbouv
force-pushed
the
gbouv/starlark-args-struct-parser
branch
from
419e88e
to
e6d5dd5
Compare
h4ck3rk3y
approved these changes
Jul 13, 2023
h4ck3rk3y
approved these changes
Jul 13, 2023
core/server/api_container/server/startosis_engine/package_io/package_io_test.go
Show resolved
Hide resolved
gbouv
force-pushed
the
gbouv/starlark-args-struct-parser
branch
from
e6d5dd5
to
ac99e70
Compare
…rtosis_parser": "struct"` is passed in the arguments JSON
gbouv
force-pushed
the
gbouv/starlark-args-struct-parser
branch
from
ac99e70
to
be9527f
Compare
victorcolombo
pushed a commit
that referenced
this pull request
Jul 17, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.9](0.80.8...0.80.9) (2023-07-17) ### Features * added a command that opens the Kurtosis Web UI ([#870](#870)) ([5098969](5098969)) * allow for relative imports from packages ([#891](#891)) ([42bedab](42bedab)) * Autocomplete file artifact name on download ([#910](#910)) ([2cedd08](2cedd08)) * Make output directory optional for files download ([#909](#909)) ([2543d9a](2543d9a)) * Starlark package arguments will be parsed as a deep Struct when `"_kurtosis_parser": "struct"` is passed in the arguments JSON ([#884](#884)) ([39ec8c2](39ec8c2)) ### Bug Fixes * fixed the log and file artifact issue ([#890](#890)) ([7f7fe7b](7f7fe7b)) * pinned go version to 1.19.10 for now ([#907](#907)) ([847a37c](847a37c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running
kurtosis run github.com/path/to/package '{"_kurtosis_parser": "struct", "arg1": "val1", "arg2": "val2", ...}'will parse the arguments as a Starlark struct, rather than a simple dictionary.Is this change user facing?
YES
References (if applicable):