feat: allow for relative imports from packages #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f6d9413
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9e6ddbd.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gyani-relative.kurtosis-docs.pages.dev |
leoporoli
reviewed
Jul 14, 2023
leoporoli
reviewed
Jul 14, 2023
...er/server/startosis_engine/startosis_packages/git_package_content_provider/parsed_git_url.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Jul 14, 2023
...sis_engine/startosis_packages/mock_package_content_provider/mock_package_content_provider.go
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Jul 14, 2023
internal_testsuites/starlark/valid-package-with-relative-imports/main.star
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Jul 14, 2023
internal_testsuites/starlark/valid-package-with-relative-imports/src/lib.star
Outdated
Show resolved
Hide resolved
leoporoli
reviewed
Jul 14, 2023
internal_testsuites/starlark/valid-package-with-relative-imports/static_files/password.txt
Show resolved
Hide resolved
leoporoli
approved these changes
Jul 14, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Jul 17, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.9](0.80.8...0.80.9) (2023-07-17) ### Features * added a command that opens the Kurtosis Web UI ([#870](#870)) ([5098969](5098969)) * allow for relative imports from packages ([#891](#891)) ([42bedab](42bedab)) * Autocomplete file artifact name on download ([#910](#910)) ([2cedd08](2cedd08)) * Make output directory optional for files download ([#909](#909)) ([2543d9a](2543d9a)) * Starlark package arguments will be parsed as a deep Struct when `"_kurtosis_parser": "struct"` is passed in the arguments JSON ([#884](#884)) ([39ec8c2](39ec8c2)) ### Bug Fixes * fixed the log and file artifact issue ([#890](#890)) ([7f7fe7b](7f7fe7b)) * pinned go version to 1.19.10 for now ([#907](#907)) ([847a37c](847a37c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow for relative imports from packages
Is this change user facing?
YES