Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add navigation bar for the kurtosis frontend #940

Merged
merged 10 commits into from Jul 19, 2023
Merged

Conversation

Peeeekay
Copy link
Contributor

@Peeeekay Peeeekay commented Jul 19, 2023

Added navigation bar for users to easily navigate between pages; also add title bar and improved usability as well.

@Peeeekay Peeeekay changed the title Pk/improve frontend fix: improve frontend Jul 19, 2023
@Peeeekay Peeeekay requested a review from h4ck3rk3y July 19, 2023 06:24
Copy link
Contributor

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How thorough should I be here? I haven't very deeply looked into stuff under src/ as far as I understand this is still in beta and you are iterating on it quite quickly.

engine/server/webapp/asset-manifest.json Show resolved Hide resolved
engine/frontend/src/component/ServiceInfo.js Show resolved Hide resolved
engine/frontend/src/component/LogView.js Show resolved Hide resolved
@Peeeekay
Copy link
Contributor Author

@Peeeekay Peeeekay merged commit 36153e2 into main Jul 19, 2023
32 checks passed
@Peeeekay Peeeekay deleted the pk/improve_frontend branch July 19, 2023 15:23
victorcolombo pushed a commit that referenced this pull request Jul 20, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.80.13](0.80.12...0.80.13)
(2023-07-20)


### Features

* Add autocomplete for file path of artifact files inspect
([#947](#947))
([f72dfce](f72dfce))


### Bug Fixes

* broken symlinks on Kurtosis packages
([#944](#944))
([fbb0aee](fbb0aee)),
closes [#846](#846)
* improve frontend
([#940](#940))
([36153e2](36153e2))
* improved error msg
([#936](#936))
([4f72ae1](4f72ae1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
@Peeeekay Peeeekay changed the title fix: improve frontend fix: add navigation bar for the kurtosis frontend Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants