fix: broken symlinks on Kurtosis packages #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary which fix the symlink problem
Peeeekay
approved these changes
Jul 19, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Jul 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.13](0.80.12...0.80.13) (2023-07-20) ### Features * Add autocomplete for file path of artifact files inspect ([#947](#947)) ([f72dfce](f72dfce)) ### Bug Fixes * broken symlinks on Kurtosis packages ([#944](#944)) ([fbb0aee](fbb0aee)), closes [#846](#846) * improve frontend ([#940](#940)) ([36153e2](36153e2)) * improved error msg ([#936](#936)) ([4f72ae1](4f72ae1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This issue was affecting symlinks files inside Kurtosis packages, when a Kurtosis package, containing a symlink file, was compressed and uploaded to the enclave's file system, the symlink reference was modified when the package was uncompressed.
The issue was generated by the
github.com/mholt/archiverdependency, which is used to generate the.tgzfile and the solution was to update it to the latest version.This PR also replaces some deprecated Golang
ioutilsfunctions in theshared_utilsfile (this isn't important to communicate in the changelog file and communications)Is this change user-facing?
YES
References (if applicable):
Fix #846