Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add autocomplete for file path of artifact files inspect #947

Merged
merged 5 commits into from Jul 20, 2023

Conversation

victorcolombo
Copy link
Contributor

@victorcolombo victorcolombo commented Jul 19, 2023

Description:

This PR adds a couple of improvements to the recent file inspect:

  1. Autocomplete for files inside the artifact
Screenshot 2023-07-19 at 13 16 57 2. Prettier coloring of files that contain a text description Screenshot 2023-07-19 at 13 25 22 3. Render correctly root level files 4. Drop artifact name on file tree

Is this change user facing?

YES

References (if applicable):

@victorcolombo victorcolombo enabled auto-merge (squash) July 19, 2023 20:56
@mieubrisse
Copy link
Member

@victorcolombo wdyt if we do the coloring like Unix default? white for regular files, and blue for directories?

@victorcolombo victorcolombo merged commit f72dfce into main Jul 20, 2023
29 checks passed
@victorcolombo victorcolombo deleted the vcolombo/polishes-inspect branch July 20, 2023 14:21
victorcolombo pushed a commit that referenced this pull request Jul 20, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.80.13](0.80.12...0.80.13)
(2023-07-20)


### Features

* Add autocomplete for file path of artifact files inspect
([#947](#947))
([f72dfce](f72dfce))


### Bug Fixes

* broken symlinks on Kurtosis packages
([#944](#944))
([fbb0aee](fbb0aee)),
closes [#846](#846)
* improve frontend
([#940](#940))
([36153e2](36153e2))
* improved error msg
([#936](#936))
([4f72ae1](4f72ae1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
@leeederek
Copy link
Contributor

Hi we're missing docs for this @victorcolombo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants