Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only forward APIC port on remote context. #1049

Merged
merged 3 commits into from Aug 3, 2023
Merged

fix: Only forward APIC port on remote context. #1049

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d4263d
Only forward APIC port on remote context.
laurentluce Aug 3, 2023
93db539
Merge branch 'main' into laurent/no_apic_forward_on_local_context
laurentluce Aug 3, 2023
5778b5c
Merge branch 'main' into laurent/no_apic_forward_on_local_context
laurentluce Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 14 additions & 7 deletions api/golang/engine/lib/kurtosis_context/kurtosis_context.go
View file
Open in desktop
Expand Up @@ -3,6 +3,8 @@ package kurtosis_context
import (
"context"
"fmt"
"io"

"github.com/Masterminds/semver/v3"
portal_constructors "github.com/kurtosis-tech/kurtosis-portal/api/golang/constructors"
portal_api "github.com/kurtosis-tech/kurtosis-portal/api/golang/generated"
Expand All @@ -11,14 +13,14 @@ import (
"github.com/kurtosis-tech/kurtosis/api/golang/core/lib/services"
"github.com/kurtosis-tech/kurtosis/api/golang/engine/kurtosis_engine_rpc_api_bindings"
"github.com/kurtosis-tech/kurtosis/api/golang/kurtosis_version"
"github.com/kurtosis-tech/kurtosis/contexts-config-store/store"
"github.com/kurtosis-tech/stacktrace"
"github.com/sirupsen/logrus"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials/insecure"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/types/known/emptypb"
"io"
)

const (
Expand Down Expand Up @@ -347,13 +349,18 @@ func newEnclaveContextFromEnclaveInfo(
portalClient portal_api.KurtosisPortalClientClient,
enclaveInfo *kurtosis_engine_rpc_api_bindings.EnclaveInfo,
) (*enclaves.EnclaveContext, error) {
// for remote contexts, we need to tunnel the APIC port to the local machine
if portalClient != nil {
apicGrpcPort := enclaveInfo.GetApiContainerHostMachineInfo().GetGrpcPortOnHostMachine()
forwardApicPortArgs := portal_constructors.NewForwardPortArgs(apicGrpcPort, apicGrpcPort, &apicPortTransportProtocol)
if _, err := portalClient.ForwardPort(ctx, forwardApicPortArgs); err != nil {
return nil, stacktrace.Propagate(err, "Unable to forward remote API container port to the local machine")
currentContext, err := store.GetContextsConfigStore().GetCurrentContext()
if err == nil {
// for remote contexts, we need to tunnel the APIC port to the local machine
if store.IsRemote(currentContext) && portalClient != nil {
apicGrpcPort := enclaveInfo.GetApiContainerHostMachineInfo().GetGrpcPortOnHostMachine()
forwardApicPortArgs := portal_constructors.NewForwardPortArgs(apicGrpcPort, apicGrpcPort, &apicPortTransportProtocol)
if _, err := portalClient.ForwardPort(ctx, forwardApicPortArgs); err != nil {
return nil, stacktrace.Propagate(err, "Unable to forward remote API container port to the local machine")
}
}
} else {
logrus.Warnf("Unable to retrieve current Kurtosis context. This is not critical, it will assume using Kurtosis default context for now.")
laurentluce marked this conversation as resolved.
Show resolved Hide resolved
}

enclaveContainersStatus := enclaveInfo.GetContainersStatus()
Expand Down