feat: Enclave inspect relying on the API container service only #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to the response
gbouv
approved these changes
Aug 7, 2023
leoporoli
pushed a commit
that referenced
this pull request
Aug 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.81.5](0.81.4...0.81.5) (2023-08-07) ### Features * Enclave inspect relying on the API container service only ([#1070](#1070)) ([da171ea](da171ea)) ### Bug Fixes * Fix broken link in docs causing CI build to fail ([#1079](#1079)) ([77d8a13](77d8a13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
leoporoli
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.81.5](0.81.4...0.81.5) (2023-08-07) ### Features * Enclave inspect relying on the API container service only ([#1070](#1070)) ([da171ea](da171ea)) ### Bug Fixes * Fix broken link in docs causing CI build to fail ([#1079](#1079)) ([77d8a13](77d8a13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current
enclave inspectcommand gets the services info from the backend and from the APIC. This is done to be able to display the enclave details even when the enclave (APIC) is stopped. In practice, inspecting a stopped enclave hasn't proven useful so we are migrating this command to only use the APIC. This change is also required by the bastion/remote host design because the CLI only has access to the remote backend APIC.The APIC provides all the information required except the service status so we are adding it to
ServiceInfo.Is this change user facing?
YES