feat: Added ReadyConditions type which is used in ServiceConfig for defining how to check services readiness
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7414662
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50a3216d.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://lporoli-740-a.kurtosis-docs.pages.dev |
gbouv
reviewed
Mar 14, 2023
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_types/service_config/service_config.go
Show resolved
Hide resolved
leoporoli
commented
Mar 14, 2023
|
@gbouv this guy is ready for a second review, thanks |
gbouv
approved these changes
Mar 16, 2023
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/ready_conditions.go
Outdated
Show resolved
Hide resolved
core/server/api_container/server/startosis_engine/recipe/http_request_recipe.go
Show resolved
Hide resolved
|
@leoporoli are we tracking to add docs about this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.