fix: name temporary python script for run_python with suitable name #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
reviewed
Oct 25, 2023
| @@ -149,6 +151,9 @@ type RunPythonCapabilities struct { | |||
| } | |||
|
|
|||
| func (builtin *RunPythonCapabilities) Interpret(_ string, arguments *builtin_argument.ArgumentValuesSet) (starlark.Value, *startosis_errors.InterpretationError) { | |||
| randomUuid := uuid.NewRandom() | |||
| builtin.name = fmt.Sprintf("task-%v", randomUuid.String()) | |||
There was a problem hiding this comment.
you can put this "task-%v" in a constant
leoporoli
approved these changes
Oct 25, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.13](0.84.12...0.84.13) (2023-10-25) ### Features * user-configurable labels (in ServiceConfig type) for Docker containers and k8s pods ([#1604](#1604)) ([e98cdf6](e98cdf6)) ### Bug Fixes * name temporary python script for run_python with suitable name ([#1616](#1616)) ([88edb39](88edb39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we would name it with a name like
tranquil-windetc and that would confuse the reader on what it might contain. The ideal solution here is to clean this up and not use a temporary files artifact at all and not use the service network inside interpret