Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use full path for running black to allow older versions of docker #1666

Merged
merged 2 commits into from Oct 31, 2023
Merged

fix: use full path for running black to allow older versions of docker #1666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca7a808
runs with older verison
h4ck3rk3y Oct 31, 2023
8f69d14
some further cleanup
h4ck3rk3y Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions cli/cli/commands/lint/lint.go
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ import (
"os"
"os/exec"
"path"
"path/filepath"
)

const (
Expand Down Expand Up @@ -154,9 +155,14 @@ func getVolumeToMountAndPathToLint(pathOfFileOrDirToLint string) (string, string
if err != nil {
return "", "", stacktrace.Propagate(err, "an error occurred while verifying that '%v' exist", pathOfFileOrDirToLint)
}
absolutePathForFileOrDirToLint, err := filepath.Abs(pathOfFileOrDirToLint)
if err != nil {
return "", "", stacktrace.Propagate(err, "tried to get absolute path for dir to lint '%v but failed'", absolutePathForFileOrDirToLint)
}

if fileInfo.IsDir() {
return pathOfFileOrDirToLint, presentWorkingDirectory, nil
return absolutePathForFileOrDirToLint, presentWorkingDirectory, nil
} else {
return path.Dir(pathOfFileOrDirToLint), path.Base(pathOfFileOrDirToLint), nil
return path.Dir(absolutePathForFileOrDirToLint), path.Base(absolutePathForFileOrDirToLint), nil
}
}