feat: emui auth via cookie #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Nov 14, 2023
# Conflicts: # enclave-manager/web/package.json # engine/server/webapp/asset-manifest.json # engine/server/webapp/index.html # engine/server/webapp/static/js/main.045e0a73.js.LICENSE.txt # engine/server/webapp/static/js/main.045e0a73.js.map # engine/server/webapp/static/js/main.616bbe7c.js.LICENSE.txt # engine/server/webapp/static/js/main.efcd178a.js.LICENSE.txt
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.32](0.85.31...0.85.32) (2023-11-20) ### Features * emui auth via cookie ([#1783](#1783)) ([d5d79d8](d5d79d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies how the AuthenticatedKurtosisClient is created by retrieving authentication material from a cookie, rather than via a passed message.
This PR adds back the connect button.
Finally, this pr adds support for locally running proxied inside of the cloud frontend behind a local nginx server. This improves the development experience of the cloud/emui portal.
Is this change user facing?
YES - This is also a breaking change and will require the corresponding change in the cloud frontend to be deployed to communicate the new auth material properly