fix: args were positioned incorrectly #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we destruct the content into `formData.args`
leoporoli
reviewed
Nov 15, 2023
enclave-manager/web/src/components/enclaves/modals/ConfigureEnclaveModal.tsx
Outdated
Show resolved
Hide resolved
leoporoli
approved these changes
Nov 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.23](0.85.22...0.85.23) (2023-11-15) ### Bug Fixes * args were positioned incorrectly ([#1799](#1799)) ([18c8b53](18c8b53)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@barnabasbusa submitted an issue that demonstrated that once run, the package would not apply the settings provided in the package
args. I identified a bug that meant that while we were submitting the data it was in the wrong position and needed to be moved up on level (destructured).In this PR we are also setting the JSON type as the default arg type.
Is this change user facing?
YES
References (if applicable):
Closes #1789