fix: only print image banner if image arch is non empty string and different #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
approved these changes
Nov 27, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.36](0.85.35...0.85.36) (2023-11-27) ### Features * emui enhancements ([#1847](#1847)) ([633ba42](633ba42)) ### Bug Fixes * make run_python not create additional files artifact ([#1851](#1851)) ([82d0058](82d0058)) * only print image banner if image arch is non empty string and different ([#1854](#1854)) ([75b8c84](75b8c84)) * tasks remove containers after they are done ([#1850](#1850)) ([179c541](179c541)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1780
we'd print the image arch banner incorrectly on k8s as the k8s backend would return ""