feat: Docker Traefik routing based on host header #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
changed the title
adschwartz
approved these changes
Dec 11, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.44](0.85.43...0.85.44) (2023-12-11) ### Features * Docker Traefik routing based on host header ([#1921](#1921)) ([7086662](7086662)) ### Bug Fixes * make push cli job use golang 1.20 ([#1925](#1925)) ([805469e](805469e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
h4ck3rk3y
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit 7086662.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Docker Traefik is currently configured to route traffic based on three custom headers: enclave short uuid, service short uuid and port number. This type of routing rule is not possible with the K8S Ingress provider so we are switching to use the single Host header instead with the format:
<port number>-<service short uuid>-<enclave short uuid>.Is this change user facing?
NO
References (if applicable):
#1906