fix: Fix calls to stacktrace in the reverse proxy module #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
approved these changes
Jan 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.13](0.86.12...0.86.13) (2024-02-05) ### Features * add `env_vars` as input to `run_sh` ([#2114](#2114)) ([5a30ea7](5a30ea7)), closes [#2050](#2050) * add nodejs devtools to Nix ([#2099](#2099)) ([7bbb2bc](7bbb2bc)) * add run docker compose with kurtosis guide ([#2085](#2085)) ([7bbe479](7bbe479)) * Add RunStarlarkScript to enclave manager API ([#2103](#2103)) ([1eeb3eb](1eeb3eb)) ### Bug Fixes * adding the `core script build call`, which was removed by accident, in the main build script ([#2118](#2118)) ([1f73821](1f73821)) * Fix calls to stacktrace in the reverse proxy module ([#2100](#2100)) ([a7fefc2](a7fefc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: Anders Schwartz <adschwartz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A user reported a Go panic in the reverse proxy module when the reverse proxy container is missing. The reverse proxy is missing because of the lack of support for podman.
Is this change user facing?
NO
References (if applicable):
https://discord.com/channels/783719264308953108/1139207537959391232/1201943594714542171