feat: Enclave connect #2117
Merged
feat: Enclave connect #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
690d92a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d23065e.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://laurent-enclave-connect.kurtosis-docs.pages.dev |
laurentluce
commented
Feb 5, 2024
adschwartz
reviewed
Feb 5, 2024
adschwartz
approved these changes
Feb 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.15](0.86.14...0.86.15) (2024-02-07) ### Features * Enclave connect ([#2117](#2117)) ([d33de7b](d33de7b)) ### Bug Fixes * Fix the enclave connect button and modal help string in the EM UI ([#2127](#2127)) ([a11fb4c](a11fb4c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We want the user to be able to connect from their local machine to an enclave with a start from the UI. A connect button is added to the enclave page with the CLI commands to paste. A CLI enclave connect command is added.
Is this change user facing?
YES
References (if applicable):
(https://www.notion.so/kurtosistech/Connect-local-CLI-to-running-enclave-workflow-for-cloud-based-enclaves-via-frontend-636d41ca937c4e49b54161aa498704b1?pvs=4)