fix: image download mode always applies to k8s as well #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
reviewed
Mar 8, 2024
..._impls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/start_user_services.go
Show resolved
Hide resolved
leoporoli
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.5](0.88.4...0.88.5) (2024-03-12) ### Features * add an add to GitHub button on an encalve ([#2256](#2256)) ([96f6771](96f6771)) ### Bug Fixes * image download mode always applies to k8s as well ([#2271](#2271)) ([2e90c67](2e90c67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier this flag was limited to Docker but now it works on k8s too
Closes #2246
Earlier
latestdefaulted toAlwaysbut now it will depend on the flag senthttps://github.com/kubernetes/api/blob/master/core/v1/types.go#L2764-L2771