fix: ImageBuildSpec build_file feature

[leovct]

Description

This PR #2223 introduced build_file in ImageBuildSpec but didn't test if it worked on a real example (my bad)... I tried to use the feature yesterday and it didn't work so I revisited my changes and made sure it works now!

To achieve that, I introduced a new Dockerfile called test.Dockerfile in internal_testsuites/starlark/image-build-package and added a new service that relies on this image.

$ ktdebug run --enclave test internal_testsuites/starlark/image-build-package
WARN[2024-03-14T12:21:29+01:00] An error occurred getting the running engine's version; you may be running an out-of-date engine version 
WARN[2024-03-14T12:21:29+01:00] We expected the running engine version to match format X.Y.Z, but instead got '921ba9'; this means that we can't verify the API library and engine versions match so you may encounter runtime errors 
INFO[2024-03-14T12:21:30+01:00] Executing Starlark package at '/Users/leovct/Documents/opensource/kurtosis/internal_testsuites/starlark/image-build-package' as the passed argument 'internal_testsuites/starlark/image-build-package' looks like a directory 
INFO[2024-03-14T12:21:30+01:00] Compressing package 'github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/image-build-package' at 'internal_testsuites/starlark/image-build-package' for upload 
INFO[2024-03-14T12:21:30+01:00] Uploading and executing package 'github.com/kurtosis-tech/kurtosis/internal_testsuites/starlark/image-build-package' 

Adding service with name 'service-1' and image 'kurtosistech/service'
SKIPPED - This instruction has already been run in this enclave

Adding service with name 'service-2' and image 'kurtosistech/service'
SKIPPED - This instruction has already been run in this enclave

Starlark code successfully run. No output was returned.

Made with Kurtosis - https://kurtosis.com
Name:            test
UUID:            1942191df821
Status:          RUNNING
Creation Time:   Thu, 14 Mar 2024 12:02:31 CET
Flags:           

========================================= Files Artifacts =========================================
UUID   Name

========================================== User Services ==========================================
UUID           Name        Ports    Status
1b5ec55bc742   service-1   <none>   STOPPED
38dafa01e996   service-2   <none>   STOPPED

Is this change user facing?

YES

References (if applicable)

[leovct]

tagging @mieubrisse @tedim52 for review :)

[gitguardian]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-		Generic Password	0d53544	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
-		Generic Password	0d53544	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
-		Generic Password	0d53544	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
-		Generic Password	0d53544	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
-		Generic Password	0d53544	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[tedim52]

Hey @leovct , is there any chance you can force undo the most recent merge commit and then merge again? (That should fix the git guardian issue)Then we can get this merged!

[leovct]

Hey @leovct , is there any chance you can force undo the most recent merge commit and then merge again? (That should fix the git guardian issue)Then we can get this merged!

Looks like it introduced a bunch of breaking changes, I'll review that on Monday :) Have a great week-end!

edit: It did not fix the git guardian issue unfortunately :(

[tedim52]

@leovct ah okay, I'll fix that on a separate branch