Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update delete instances request #2445

Merged
merged 3 commits into from
May 13, 2024
Merged

feat: update delete instances request #2445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791063e
update delete instances request
tedim52 May 10, 2024
ee2b54a
rename api key
tedim52 May 13, 2024
191cfc4
Merge branch 'main' into tedi/deleteinstanceupdate
tedim52 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/golang/core/kurtosis_core_rpc_api_bindings/api_container_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/rust/src/api_container_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ pub struct GetStarlarkRunResponse {
pub experimental_features: ::prost::alloc::vec::Vec<i32>,
#[prost(enumeration = "RestartPolicy", tag = "8")]
pub restart_policy: i32,
/// The params that were used for the very first run of the script
/// The params that were used on for the very first Starlark run in an APIC
#[prost(string, optional, tag = "9")]
pub initial_serialized_params: ::core::option::Option<
::prost::alloc::string::String,
Expand Down
2 changes: 1 addition & 1 deletion api/typescript/src/core/kurtosis_core_rpc_api_bindings/connect/api_container_service_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ export declare class GetStarlarkRunResponse extends Message<GetStarlarkRunRespon
restartPolicy: RestartPolicy;

/**
* The params that were used for the very first run of the script
* The params that were used on for the very first Starlark run in an APIC
*
* @generated from field: optional string initial_serialized_params = 9;
*/
Expand Down
779 changes: 397 additions & 382 deletions cloud/api/golang/kurtosis_backend_server_rpc_api_bindings/kurtosis_backend_server_api.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions ...pi/golang/kurtosis_backend_server_rpc_api_bindings/kurtosis_backend_server_api_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 18 additions & 18 deletions ...gs/kurtosis_backend_server_rpc_api_bindingsconnect/kurtosis_backend_server_api.connect.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 11 additions & 6 deletions cloud/api/protobuf/kurtosis_backend_server_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ service KurtosisCloudBackendServer {
rpc CancelPaymentSubscription (CancelPaymentSubscriptionArgs) returns (google.protobuf.Empty) {};
rpc UpdateAddress(UpdateAddressArgs) returns (google.protobuf.Empty) {};
rpc GetInstances(google.protobuf.Empty) returns (GetInstancesResponse) {};
rpc DeleteInstance(DeleteInstanceRequest) returns (DeleteInstanceResponse) {};
rpc DeleteInstances(DeleteInstancesRequest) returns (DeleteInstancesResponse) {};
rpc ChangeActiveStatus(ChangeUserActiveRequest) returns (google.protobuf.Empty) {};
rpc GetUser(GetUserRequest) returns (GetUserResponse) {};
rpc CheckPortAuthorization(CheckPortAuthorizationRequest) returns(google.protobuf.Empty){
Expand Down Expand Up @@ -156,13 +156,18 @@ message UpdateAddressArgs {
string country = 8;
}

message DeleteInstanceRequest {
string instance_id = 1;
string ec2_id = 2;
tedim52 marked this conversation as resolved.
Show resolved Hide resolved
message DeleteInstancesRequest {
repeated string instance_ids = 1;

// must be system user to delete instances
string api_key = 2;

// can optionally pass a status to only delete instances with a certain status, eg. configuring
optional string status = 3;
}

message DeleteInstanceResponse {
string status = 1;
message DeleteInstancesResponse {
repeated string deleted_instances = 1;
}

message GetInstancesResponse {
Expand Down