fix: Rollback to previous cluster when cluster set fails #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
approved these changes
May 22, 2023
victorcolombo
pushed a commit
that referenced
this pull request
May 23, 2023
🤖 I have created a release *beep* *boop* --- ## [0.76.8](0.76.7...0.76.8) (2023-05-23) ### Features * Return error on SDK if Starlark run on any step ([#634](#634)) ([8a01cff](8a01cff)) ### Bug Fixes * Make printWarningIfArgumentIsDeprecated unit test deterministic ([#633](#633)) ([46bbee5](46bbee5)) * Rollback to previous cluster when cluster set fails ([#631](#631)) ([0e212c9](0e212c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When
kurtosis cluster setfails, we wrongly callkurtosis cluster setonclusterNameagain instead of rolling back toclusterPriorToUpdateas intended.Is this change user facing?
YES
References (if applicable):