feat: allow to pop a shell on Kubernetes #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2023-06-20.at.12.58.24.PM.mov |
gbouv
approved these changes
Jun 21, 2023
...-lib/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/kubernetes_kurtosis_backend.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
pushed a commit
that referenced
this pull request
Jun 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.79.0](0.78.5...0.79.0) (2023-06-21) ### ⚠ BREAKING CHANGES * removed workdir from run_sh and fixed some typos on the doc ([#739](#739)) ### Features * allow to pop a shell on Kubernetes ([#748](#748)) ([3c706e5](3c706e5)) ### Bug Fixes * removed workdir from run_sh and fixed some typos on the doc ([#739](#739)) ([6406f10](6406f10)) * Support for reconnects in the Gateway port forwarder ([#736](#736)) ([4944ccd](4944ccd)), closes [#726](#726) * typos ([#742](#742)) ([800e523](800e523)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously popping a shell was three different kubectl commands. Now its one Kurtosis command
Is this change user facing?
YES