Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove existing package directory if it already exists in APIC #818

Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix: Remove existing package directory if it already exists in APIC #818

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
217d45b
Remove existing package directory if it already exists in APIC
Jul 5, 2023
3584be9
Merge branch 'main' into gbouv/remove-package-if-already-exist
Jul 5, 2023
e554ea9
Merge branch 'main' into gbouv/remove-package-if-already-exist
Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...is_engine/startosis_packages/git_package_content_provider/git_package_content_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ func (provider *GitPackageContentProvider) atomicClone(parsedURL *ParsedGitURL)
return startosis_errors.WrapWithInterpretationError(err, "Cloning the package '%s' failed. An error occurred while creating the directory '%s'.", parsedURL.gitURL, packageAuthorPath)
}
}
if _, err = os.Stat(packagePath); !os.IsNotExist(err) {
logrus.Debugf("Package '%s' already exists in enclave at path '%s'. Going to remove previous version.", parsedURL.gitURL, packagePath)
if err = os.RemoveAll(packagePath); err != nil {
return startosis_errors.NewInterpretationError("Unable to remove a previous version of package '%s' existing inside Kurtosis enclave at '%s'.", parsedURL.gitURL, packagePath)
}
}
if err = os.Rename(gitClonePath, packagePath); err != nil {
return startosis_errors.NewInterpretationError("Cloning the package '%s' failed. An error occurred while moving package at temporary destination '%s' to final destination '%s'", parsedURL.gitURL, gitClonePath, packagePath)
}
Expand Down