fix: Fix successfully executed bug in APIC logs when script fails
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
approved these changes
Jul 24, 2023
gbouv
changed the title
successfully executed bug in APIC logs when script failssuccessfully executed bug in APIC logs when script fails
Peeeekay
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.14](0.80.13...0.80.14) (2023-07-24) ### Features * Add ability to update a running service ([#943](#943)) ([42a67f9](42a67f9)) * added create enclave flow ([#962](#962)) ([4c931b8](4c931b8)) * Idempotent run V1 - services can now be live-updated inside an enclave ([#954](#954)) ([a6a118d](a6a118d)) ### Bug Fixes * Fix `successfully executed` bug in APIC logs when script fails ([#964](#964)) ([32fe63f](32fe63f)) * no magic string replacement in python packages ([#966](#966)) ([8b0fa62](8b0fa62)) * the old go download ([#958](#958)) ([f1b52ca](f1b52ca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #960
Is this change user facing?
NO
References (if applicable):