fix: Fix error swallowing in DefaultServiceNetwork.destroyService #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/destroy-service-error-handling
branch
from
7ea5573
to
44da0fc
Compare
h4ck3rk3y
approved these changes
Jul 28, 2023
core/server/api_container/server/service_network/default_service_network.go
Show resolved
Hide resolved
core/server/api_container/server/service_network/default_service_network.go
Show resolved
Hide resolved
core/server/api_container/server/service_network/default_service_network.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
reviewed
Jul 28, 2023
core/server/api_container/server/service_network/default_service_network.go
Show resolved
Hide resolved
adschwartz
pushed a commit
that referenced
this pull request
Jul 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.23](0.80.22...0.80.23) (2023-07-31) ### Features * add `cloud add` ([#1015](#1015)) ([48aecd0](48aecd0)) ### Bug Fixes * Fix error swallowing in DefaultServiceNetwork.destroyService ([#987](#987)) ([828f366](828f366)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #979
Is this change user facing?
NO
References (if applicable):