Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarLintに基づいたリファクタリングを実施 #752

Merged
merged 20 commits into from Jun 24, 2020
Merged

SonarLintに基づいたリファクタリングを実施 #752

merged 20 commits into from Jun 24, 2020

Conversation

hnymA
Copy link
Contributor

@hnymA hnymA commented Jun 22, 2020 •
edited

resolved #747

@hnymA hnymA changed the title [WIP] リファクタリングを実施 リファクタリングを実施 Jun 23, 2020
@hnymA hnymA requested review from hrtwt and raedion June 23, 2020 03:46
@shinsuke-mat shinsuke-mat mentioned this pull request Jun 23, 2020
Merged
@shinsuke-mat shinsuke-mat changed the title リファクタリングを実施 SonarLintに基づいたリファクタリングを実施 Jun 23, 2020
@shinsuke-mat shinsuke-mat removed the request for review from raedion June 23, 2020 03:56
hrtwt
hrtwt approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@hrtwt hrtwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntuで動かしてみましたが，1通り動いてそうでした．
お疲れ様でした．

@hnymA hnymA merged commit e0cb3a9 into master Jun 24, 2020
@hnymA hnymA deleted the refactor branch June 24, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrtwt hrtwt hrtwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

リファクタリングしたい
2 participants
@hnymA @hrtwt