kgpMainでの異常系処理を追加 #802
Merged
kgpMainでの異常系処理を追加 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnymA
requested changes
Dec 2, 2020
|
|
||
| @Test | ||
| public void test04() { | ||
| assertEquals(-9, new CloseToZero().close_to_zero(-10)); |
There was a problem hiding this comment.
Suggested change
| assertEquals(-9, new CloseToZero().close_to_zero(-10)); | |
| assertEquals(-9, new CloseToZero().close_to_zero(-8)); |
じゃないでしょうか
There was a problem hiding this comment.
assertEquals は expect, actual の順で書くのでこれで正しい．
Assertj#assertThat は（英語文法とassertjの仕組み上）actual, expect の順で書くので混同しがち．
|
|
||
| @Test | ||
| public void test04() { | ||
| assertEquals(-9, new CloseToZero().close_to_zero(-10)); |
| @@ -17,8 +18,12 @@ | |||
| * @deprecated | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
コンストラクタが必要であれば @deprecated は削除した方が良いと思います
There was a problem hiding this comment.
agree
至った過程をメモしておく．
このクラスはsingletonにする予定，かつ別のクラスが参照していたので，tech debtのつもりで @Depre にしてあった．
でもこのクラスはある失敗を表すクラスで，そもそもsingletonであるべきではない．失敗の理由を記載できなくなる．
そのためdepreするべきではない．
| @@ -8,6 +9,8 @@ | |||
| import org.junit.Rule; | |||
| import org.junit.Test; | |||
| import org.junit.rules.TemporaryFolder; | |||
| import ch.qos.logback.classic.Level; | |||
There was a problem hiding this comment.
unusedなので除去してください
このPRには関係ないですが，↓の import jp.kusumotolab.kgenprog.ga.variant.Variant; もunusedなのでついでに除去をお願いします
hnymA
approved these changes
Dec 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #610
resolve #645
resolve #734
resolve #740
kGenProgMainの異常系処理を追加．
利用者目線での利便性が向上．
やったこと
本質
上に付随
その他リファクタリング系
無駄なRuntimeException宣言を削除
無駄なTestExecutor#finish #initializeを削除
Mainクラスでのログ出力周りをinner class化，さらに改善