-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PatchExporterの責務をFileとLogに分割 #804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
============================================
+ Coverage 80.58% 80.60% +0.02%
Complexity 937 937
============================================
Files 151 152 +1
Lines 3672 3676 +4
Branches 273 274 +1
============================================
+ Hits 2959 2963 +4
Misses 605 605
Partials 108 108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです.
マージします
resolve (a half part of) #801
やったこと
PatchExporterがコンソール出力とファイル出力の両方を行っていたため #801 の問題が出ていた.
2つの責務を分割した.
あわせてテストも分割した.
ついでにファサードクラス
Exporters
の受け口周りを少し改善.