Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchExporterの責務をFileとLogに分割 #804

Merged
merged 8 commits into from Dec 7, 2020
Merged

Conversation

shinsuke-mat
Copy link
Member

resolve (a half part of) #801

やったこと

PatchExporterがコンソール出力とファイル出力の両方を行っていたため #801 の問題が出ていた.
2つの責務を分割した.
あわせてテストも分割した.

ついでにファサードクラス Exporters の受け口周りを少し改善.

@codecov-io
Copy link

Codecov Report

Merging #804 (50b3b00) into master (8367788) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #804      +/-   ##
============================================
+ Coverage     80.58%   80.60%   +0.02%     
  Complexity      937      937              
============================================
  Files           151      152       +1     
  Lines          3672     3676       +4     
  Branches        273      274       +1     
============================================
+ Hits           2959     2963       +4     
  Misses          605      605              
  Partials        108      108              
Impacted Files Coverage Δ Complexity Δ
...java/jp/kusumotolab/kgenprog/output/Exporters.java 86.20% <100.00%> (ø) 9.00 <3.00> (-2.00)
...kusumotolab/kgenprog/output/PatchFileExporter.java 82.85% <100.00%> (ø) 9.00 <2.00> (?)
.../kusumotolab/kgenprog/output/PatchLogExporter.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bdede...739023f. Read the comment docs.

Copy link
Contributor

@ty-v1 ty-v1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです.
マージします

@ty-v1 ty-v1 merged commit 397c1ae into master Dec 7, 2020
@ty-v1 ty-v1 deleted the separate-exporters branch December 7, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants