ファイル出力オプションの名前/挙動を自然な形に変更 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem. Good job! |
Merged
hrtwt
requested changes
Dec 8, 2020
README.md
Outdated
| @@ -93,7 +93,7 @@ $ java -jar path/to/kGenProg.jar | |||
| | `-t`, `--test` | Specifies paths to test source code, or to directories containing them. Paths are separated with spaces. | Nothing | | |||
| | `-x`, `--exec-test` | Specifies fully qualified names of test classes executed during evaluation of variants (i.e. fix-candidates). It is recommended to specify test classes detecting a bug. Class names are separated with spaces. | All test classes | | |||
| | `-c`, `--cp` | Specifies class paths needed to build the target project. Paths are separated with spaces. | Nothing | | |||
| | `-o`, `--out-dir` | Writes patches kGenProg generated under the specified directory. Patches are outputted to a directory having a name of the execution time and date under the specified directory. | A directory named `kgenprog-out` is created in the current directory. | | |||
| | `-o`, `--out-dir` | Specifies an output directory. Generated files include patches and history json. They can be enabled by `--patch-output` or `--history-record` | A directory named `kgenprog-out` is created in the current directory. | | |||
There was a problem hiding this comment.
doc/ja/README.md （日本語版）にも同様の変更をお願いします
README.md
Outdated
Comment on lines
114
to
115
| | `--patch-output` | Writes patch files to the output directory specified in `-o` option. | `false` | | ||
| | `--history-record` | Records and writes generation process of all generated variants as JSON format. | `false` | |
Comment on lines
+318
to
+321
| @com.electronwill.nightconfig.core.conversion.Path("patch-output") | ||
| @PreserveNotNull | ||
| private boolean isPatchOutput = DEFAULT_IS_PATCH_OUTPUT; | ||
|
|
There was a problem hiding this comment.
doc/kgenprog-config-template.toml への反映もお願いします
| public class ExportersTest { | ||
|
|
||
| @Test | ||
| public void testInstanciationWithPreviousResults() throws IOException { |
There was a problem hiding this comment.
typo の修正をお願いします
Suggested change
| public void testInstanciationWithPreviousResults() throws IOException { | |
| public void testInstantiationWithPreviousResults() throws IOException { |
|
thx 指摘部分を修正しました． |
hrtwt
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #801
depends PR #804
notes
PR #804 からの派生ブランチである点に注意．
PR #804 解決後にreviewしてください．
行儀の悪いPRだけど依存を持つので仕方なし．レビュー時のファイル差分はこっち見て下さい．https://github.com/kusumotolab/kGenProg/compare/better-exporter-params..separate-exporters?w=1#804 がマージされたのでmasterからマージさせておいた．
行儀の悪さは解消．
やったこと
tungled
kgpMainTestのファイル出力の指定周りを改善
ExporterTest の CRLF → LF