Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Remove the requirement of email being configured #4

Closed
wants to merge 1 commit into from

Conversation

mvrhov
Copy link
Contributor

@mvrhov mvrhov commented Feb 26, 2014

No description provided.

@kutny
Copy link
Owner

kutny commented Feb 26, 2014

Why don't you want email to be required?

@mvrhov
Copy link
Contributor Author

mvrhov commented Feb 26, 2014

Because this is forcing me to have email defined in dev environment

@kutny
Copy link
Owner

kutny commented Feb 26, 2014

But you can set it with

kutny_tracy:
emails: []

in config_dev.yml. Do you see any problem with this approach?

@mvrhov
Copy link
Contributor Author

mvrhov commented Feb 26, 2014

Other than it looks weird and adds "unnecessary" config setting into the dev?

@kutny
Copy link
Owner

kutny commented Mar 11, 2014

Well I wanted to make "emails" option mandatory to explicitly tell the bundle user: "Hey, its very important to set this option. If you don't do it, you will not receive notifications about app errors. Don't forget to set it"

If the user does not want to receive notifications, he/she must explicitly set "emails" with an empty array. Yes, most of the bundle users do not want to receive notifications on the dev environment during app development. However setting "emails" with an empty array is so easy, that I really think that it is a "good enough" solution.

@mvrhov
Copy link
Contributor Author

mvrhov commented Mar 11, 2014

fair enough

@mvrhov mvrhov closed this Mar 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants